On Mon, 2016-05-16 at 18:40 -0400, Robbie Harwood wrote:
Simo Sorce <simo(a)redhat.com> writes:
> On Mon, 2016-05-16 at 15:15 -0400, Robbie Harwood wrote:
>
>> - ret_maj = gp_conv_gssx_to_name(&ret_min, desired_name,
&req_name);
>> + ret_min = gp_conv_gssx_to_name(&ret_min, desired_name,
&req_name);
>
> nack, this clobbers the real ret_min.
> we probably need to move the checks in he above if/else and have each
> function check heir own.
> We probably want to return the actual ret_maj instead of
> GSS_S_CRED_UNAVAIL in the else branch anyway.
So it does. How about this instead?
Sounds better.
Simo.
--
Simo Sorce * Red Hat, Inc * New York