* Carlos O'Donell:
On 11/21/18 1:12 PM, Florian Weimer wrote:
> I would like to see a quick review for this.
>
> I think have to do this, which is unfortunate. It increases build time
> by about ten minutes on x86-64 (with lots of CPU cores).
>
> Proposed patch:
>
> diff --git a/glibc.spec b/glibc.spec
> index 73ecd93..54c96b2 100644
> --- a/glibc.spec
> +++ b/glibc.spec
> @@ -908,7 +908,9 @@ make -j1 install_root=%{glibc_sysroot} install -C
build-%{target}
> # locales.
> %ifnarch %{auxarches}
> pushd build-%{target}
> -make %{?_smp_mflags} -O install_root=%{glibc_sysroot} \
> +# Do not use a parallel make here because the hardlink optimization in
> +# localedef is not fully reproducible when running concurrently.
> +make install_root=%{glibc_sysroot} \
> install-locales -C ../localedata objdir=`pwd`
> popd
> %endif
>
> I think this could also explain the x86_64/i686 multilib differences for
> the locale archive that we saw downstream occasionally.
This is fine with me.
My *preference* would be to do a parallel install, followed by hardlink
de-dup pass that we write and execute as part of the build. I think those
two things can use multiple threads and save on the time.
Right, but that needs some sort of --no-hard-link option for localedef,
I think.
Thanks,
Florian