On 11/28/18 2:23 AM, Florian Weimer wrote:
* Carlos O'Donell:
> I'm cleaning out some old bugs and I came across this one
> which I hadn't finished.
>
> In bug 1352973 we discussed adding libgcc%{_isa} to glibc's
> requires because the cancellation API requires it.
>
> Given the current use of 'Requires: libgcc%{_isa}' for
> glibc-devel, it seems sensible to add this to glibc also.
>
> The question is, should it be added only for non-bootstrap
> builds?
No, we should keep the differences to a minimum.
> Or should we just fix it like this?
>
> diff --git a/glibc.spec b/glibc.spec
> index d553c5b..0e3b0d2 100644
> --- a/glibc.spec
> +++ b/glibc.spec
> @@ -1,6 +1,6 @@
> %define glibcsrcdir glibc-2.28.9000-319-gce035c6e90
> %define glibcversion 2.28.9000
> -%define glibcrelease 22%{?dist}
> +%define glibcrelease 23%{?dist}
> # Pre-release tarballs are pulled in from git using a command that is
> # effectively:
> #
> @@ -167,6 +167,10 @@ Provides: ldconfig
>
> # The dynamic linker supports DT_GNU_HASH
> Provides: rtld(GNU_HASH)
> +
> +# We need libgcc for cancellation support in POSIX threads.
> +Requires: libgcc%{_isa}
Maybe drop the requirement from glibc-devel because it is now redundant?
Good idea. Fixed and pushed.
--
Cheers,
Carlos.