On Tue, 2012-11-06 at 12:17 -0500, David Malcolm wrote:
On Thu, 2012-10-18 at 11:37 -0500, David Narvaez wrote:
> On Thu, Oct 18, 2012 at 10:19 AM, David Malcolm <dmalcolm(a)redhat.com> wrote:
> > Good to hear; thanks for trying it and reporting back.
> >
> > This may sound like a strange question, but when you say it "worked
> > great", presumably it builds, but does the test suite pass? I sent the
> > patch thinking that we'd have to have a bit of to-and-fro on this
> > mailing list, and I'm a bit disturbed that it worked first time :)
>
> Didn't try to run the test suite (the Gentoo ebuild would only run the
> test suite if you have the test feature globally enabled) so "worked
> great" means it compiled the plugin and created the documentation.
> Notice that creating the documentation requires a load of the plugin,
> so I know it at least loads. I'll try to run a test suite as soon as I
> have a chance.
Thanks.
I've now committed a version of the patch, together with various other
ones that suppress compiler warnings, and the plugin code is "master"
can now be compiled on my machine with -Wall -Werror against:
- "vanilla" build of gcc 4.7.latest from svn (which is built using C++)
- Fedora 17's build of gcc 4.7.2 (built using C; gcc-4.7.2-2.fc17.x86_64
to be precise)
One issue for all of the above is that although the plugin may need
building using either a C or C++ compiler (depending on the version of
gcc we're targetting), the test suite assumes a C compiler for its C
tests, and a C++ compiler for its C++ tests.
So I've been doing this for now by running:
make plugin CC=/PATH/TO/g++
to build the plugin using C++, then:
make CC=/PATH/TO/gcc
to run the test suite, which is clearly clumsy. I hope that there's a
better way to do it (perhaps by passing "-x c++" if needed during
compilation?)
As noted in the other thread, as of
http://git.fedorahosted.org/cgit/gcc-python-plugin.git/commit/?id=0ff8879...
the plugin's Makefile now tries to autodetect whether or not it needs to
build with C or C++, and passes "-x c++" if need be; you'll need to
"make clean" first.
I'm interested in hearing how well this works for other people's
configurations.
Dave