On Tue, 2012-10-02 at 06:58 +0200, tim.lauridsen(a)gmail.com wrote:
On Mon, Oct 1, 2012 at 7:34 PM, Pierre-Yves Chibon
<pingou(a)pingoured.fr> wrote:
On Mon, 2012-10-01 at 19:10 +0200, Pierre-Yves Chibon wrote:
>
> Unfortunately, it seems that the unit-tests are not working
properly.
One thing I just figured out, we are using:
from subprocess import call, Popen, PIPE, STDOUT, check_output
in FedoraReview/workspace/src/FedoraReview/mock.py (line 28),
while
check_output was introduce in python 2.7
This means that FedoraReview is no longer working on EL6
(python 2.6.6)
I'm trying to build FR against 2.7 on the jenkins :)
if check_output is the only problem, maybe adding this would be a
good
idea, EL6 support would be nice to have
https://gist.github.com/1027906
I like this,but for jenkins I am seeing more problems such as:
File
"/home/hudson/.hudson/jobs/FedoraReview/workspace/test/fr_testcase.py",
line 72, in init_test
os.chdir(cd)
OSError: [Errno 2] No such file or directory:
'/home/hudson/.hudson/jobs/FedoraReview/workspace/options'
or
File "/home/hudson/.hudson/jobs/FedoraReview/workspace/test/test_options.py",
line 143, in test_version
output = subprocess.check_output(cmd, shell=True)
File "/usr/lib/python2.7/subprocess.py", line 537, in check_output
raise CalledProcessError(retcode, cmd, output=output)
CalledProcessError: Command '../src/fedora-review --version' returned non-zero
exit status 127
or
File
"/home/hudson/.hudson/jobs/FedoraReview/workspace/src/FedoraReview/settings.py",
line 52, in _check_mock_grp
mock_gid = grp.getgrnam('mock')[2]
KeyError: 'getgrnam(): name not found: mock'
I am not sure we will be able to fix this last one... :-/
Ideas welcome
Pierre