On 03/02/15 16:12, Michel Alexandre Salim wrote:
Hi Stanislav, Alec,
Updated patch incorporating your feedback. I've tested it
manually and
ran the make_release process as well; seems not to introduce any
regression, but more eyeballs definitely appreciated.
Looks fine at a glance, but:
[al@snorken FedoraReview]$ git rev-parse HEAD
811d6701221f72ab7835e0b4c05ba37cc2ef29d5
[mk@snorken FedoraReview]$ patch -p1 < 0001-Adjust-license-checker-*
patching file plugins/generic.py
Hunk #3 FAILED at 744.
1 out of 4 hunks FAILED -- saving rejects to file plugins/generic.py.rej
[al@snorken FedoraReview]$
BTW; while we're on it: perhaps you could make the private instance
variables private:
self.license_macro -> self._license_macro
self.lkicense_flag -> self._license_flag.
If not for anything else, just to keep pylint happy.
Cheers!
--alec