On Mon, 2011-05-23 at 15:04 +0200, Nikola Pajkovsky wrote:
Jiri Moskovcak <jmoskovc(a)redhat.com> writes:
> On 05/22/2011 09:28 PM, Denys Vlasenko wrote:
>> On Fri, 2011-05-20 at 14:08 +0200, Jiri Moskovcak wrote:
>>> I pushed the proposed changes,
>>
>> add_basics_to_problem_data needs to g_list_free(list)
>> the list of keys. I am going to push a fix.
>>
>>> the only thing which has left to fix is
>>> getting the component name (problem_data.c: 129). I need to ask rpm for
>>> it and there are few possible solution:
>>>
>>> 1. call abrt-action-save-package-data
>>> 2. $ rpm -qf executable
>>> 3. use librpm
>>>
>>> Suggestions?
>>
>> I propose to add abrt-action-save-package-data call to reporters.
>>
>
> - ok, Nikola is working on adding this to bz plugin
Yep, working on it. Denys, Jiri, do you want to simple call
SavePackageDescriptionToDebugDump or split that giant function into
a small separate functions and be able call those small functions? Do you
want to store it into dump dir?
I think it woulr be cleaner if abrt-action-bugzilla knows nothing about
packages and rpm db.
How about this patch? -
--
vda
diff -x '*.po' -d -urpN abrt.4/src/daemon/abrt_event.conf
abrt.5/src/daemon/abrt_event.conf
--- abrt.4/src/daemon/abrt_event.conf 2011-05-23 17:05:41.136232392 +0200
+++ abrt.5/src/daemon/abrt_event.conf 2011-05-23 17:10:46.661670995 +0200
@@ -75,5 +75,9 @@ EVENT=post-create analyzer=Python
} 2>/dev/null
-EVENT=report_Bugzilla analyzer=Python abrt-action-bugzilla -c
/etc/abrt/plugins/Bugzilla.conf
-EVENT=report_Logger abrt-action-print -o
"${Log_File:-/tmp/abrt.log}" -a "${Append:-no}" -r
+EVENT=report_Bugzilla analyzer=Python
+ test -f component || abrt-action-save-package-data
+ abrt-action-bugzilla -c /etc/abrt/plugins/Bugzilla.conf
+
+EVENT=report_Logger
+ abrt-action-print -o "${Log_File:-/tmp/abrt.log}" -a
"${Append:-no}" -r
diff -x '*.po' -d -urpN abrt.4/src/plugins/ccpp_events.conf
abrt.5/src/plugins/ccpp_events.conf
--- abrt.4/src/plugins/ccpp_events.conf 2011-05-23 17:03:15.000000000 +0200
+++ abrt.5/src/plugins/ccpp_events.conf 2011-05-23 17:11:05.734822284 +0200
@@ -34,4 +34,5 @@ EVENT=analyze_RetraceServer analyzer=CCp
abrt-action-analyze-backtrace
EVENT=report_Bugzilla analyzer=CCpp
+ test -f component || abrt-action-save-package-data
abrt-action-bugzilla -c /etc/abrt/plugins/Bugzilla.conf