On 11/26/2009 06:21 PM, Denys Vlasenko wrote:
They are:
/usr/bin/abrt-pyhook-helper
/usr/libexec/hookCCpp
Both names and paths are different.
I propose using abrt-xxx scheme for every binary's name
(btw, maybe for dumpoops too?).
That will fix one discrepancy - in the name.
Does it make sense to move abrt-pyhook-helper to /usr/libexec?
Currently, we are using the fact that it is in /usr/bin
by not specifying the /path/to/it when we call it:
command = ["abrt-pyhook-helper"]
command.append("--pid=%s" % pid)
command.append("--executable=%s" % executable)
command.append("--uuid=%s" % tb_uuid)
I usually like this, but here it maybe isn't the best idea.
What if /usr/bin is NOT in the $PATH at this point, in this python
script?
If we decide to have a full path there, then also moving to /usr/libexec
looks like a no-brainer.
What say you?
--
+1 to abrt-xxxx naming scheme
And I would move all hooks to /usr/libexec as this is where helpers
should be.
Jirka
vda