On 02/25/2013 01:51 PM, Martin Milata wrote:
Seems ok. Two non-technical remarks:
On Mon, Feb 25, 2013 at 12:52:24 +0100, Jakub Filak wrote:
> - closes #127
>
> Signed-off-by: Jakub Filak <jfilak(a)redhat.com>
> ---
[...]
> + add_warning(
> +_("Processing of the problem failed. This can have many reasons but there are
two most common:\n"\
> +"\t▫ <b>network connection problems</b>\n"\
> +"\t▫ <b>corrupted problem's data</b>\n"));
^^ sounds weird to me, I'd just use "problem
data"
[...]
> +++ b/src/plugins/report_DumpDirForAnalysis.xml.in
> @@ -0,0 +1,21 @@
> +<?xml version="1.0" encoding="UTF-8" ?>
> +<event>
> + <_name>Dump dir analysis</_name>
> + <_description>Upload a dump dir for analysis</_description>
I think the name should indicate that the event is related to abrt
itself malfunctioning as opposed to the "normal workflow". The phrases
"dump dir" and "analysis" phrases are used in the "normal"
context as
well, so the name might be confusing. Can't think of better name myself,
though ...
- I agree, I would like to avoid of using these terms, they don't say
much to users, it should be something like "Upload the problem data for
further analysis"