On 04/01/2010 06:03 PM, Denys Vlasenko wrote:
On Thu, 2010-04-01 at 16:06 +0200, Jiri Moskovcak wrote:
> On 04/01/2010 04:05 PM, Nikola Pajkovsky wrote:
>> Looks good.
>>
>> Reviewed by: Nikola Pajkovsky<npajkovs(a)redhat.com>
>>
>> On 04/01/2010 03:38 PM, Denys Vlasenko wrote:
>>>
https://bugzilla.redhat.com/show_bug.cgi?id=551989
>>>
>>> Apparently self.dlist.get_selection() sometimes returns None.
>>> This patch takes care of this case.
>>>
>>> Please review.
> Good catch,
> but I would rather use dumplist_get_selected() everywhere so we don't
> duplicate the code and then the fix would be on one place.
Like this?
I'm getting this error after applying you patch:
....
File "CCMainWindow.py", line 324, in dumplist_get_selected
dumpsListStore, path = self.dumplist_get_selected()
File "CCMainWindow.py", line 324, in dumplist_get_selected
dumpsListStore, path = self.dumplist_get_selected()
File "CCMainWindow.py", line 324, in dumplist_get_selected
dumpsListStore, path = self.dumplist_get_selected()
File "CCMainWindow.py", line 324, in dumplist_get_selected
dumpsListStore, path = self.dumplist_get_selected()
File "CCMainWindow.py", line 324, in dumplist_get_selected
dumpsListStore, path = self.dumplist_get_selected()
File "CCMainWindow.py", line 324, in dumplist_get_selected
dumpsListStore, path = self.dumplist_get_selected()
File "CCMainWindow.py", line 324, in dumplist_get_selected
dumpsListStore, path = self.dumplist_get_selected()
RuntimeError: maximum recursion depth exceeded
because there is an old function called: dumplist_get_selected() so I
removed it in attached patch, works fine now.
Reviewed by: jmoskovc(a)redhat.com