On 08/02/2011 03:42 PM, Denys Vlasenko wrote:
On Fri, 2011-07-22 at 13:37 +0200, Miroslav Lichvar wrote:
> +char *format_report_result(const struct report_result *result)
> +{
> + const char *type_string;
> +
> + switch (result->type)
> + {
> + case REPORT_RESULT_TYPE_URL:
> + type_string = "URL";
> + break;
> + case REPORT_RESULT_TYPE_MESSAGE:
> + type_string = "MSG";
> + break;
> + default:
> + assert(0);
> + }
> + return xasprintf("%s: TIME=%s %s=%s", result->event,
> + iso_date_string(&result->timestamp), type_string,
result->data);
> +}
Before this patch, the prefix indicated the type of report:
RHTSupport:<DATA>
meant "we reported it to RHTSsupport". This is needed to be able
to figure out what<DATA> means.
Now, you print event name instead. What will happen if reporting
is hooked, for example, to "post-create" event? It will be:
post-create:<DATA>
Now it is impossible to figure out, was it reported to RHTSupport?
Bugzilla? Sent by email?
actually it adds the event name not the even type:
report_Logger: TIME=2011-07-22-23:32:03 URL=file:///home/jmoskovc/abrt.log
report_Bugzilla: TIME=2011-07-29-10:35:32
URL=https://bugzilla.redhat.com/show_bug.cgi?id=714989
- we can probably remove the report_ but it's easier to look for the
matching event, if we have the whole name...