On 07/11/2012 03:26 PM, Denys Vlasenko wrote:
On 07/11/2012 01:15 PM, Jiri Moskovcak wrote:
> On 07/11/2012 11:45 AM, Denys Vlasenko wrote:
>> Hi,
>>
>> I propose the following attached patches:
>>
>> Patch 1 removes the wrappers. I don't see why we need them.
>> Also removes CD_FLAG_FILE, we have CD_FLAG_BIN which is the same.
>>
>> Patches 2 and 3 simplify save_dump_dir_from_problem_data() code
>> and the method it uses to pass back the name of the created directory.
>> Also, move its decl into problem_data.h - I feel it belongs here.
>>
>> These are pretty mechanical changes, which open up the way for
>> the next step:
>>
>
> - the API I've created is meant for 3rd party apps which doesn't know
> (adn doesn't want to know!!) ABRT/libreport internals
Why is it necessary to insulate 3rd party apps from knowing that
libreport package exists?
For an analogy: GTK does not wrap GLib APIs. There is no need to hide Glib
for GTK users.
- because in this use case, 3rd party apps (and our hooks) just want to
report problem to ABRT not to study libreport, so why should they waste
time with libreport and trying to find out which flag to use?
- that's why I don't want to expose *_ext functions I want the API to be
super easy so developers will actually consider using it...
> and that's the reason why problem_data_save() should be available
> publicly
I have nothing against problem_data_save() being exported.
- but your patch hides it..
--J.