On 12/16/2010 03:33 PM, Nikola Pajkovsky wrote:
On 12/16/2010 03:12 PM, Denys Vlasenko wrote:
> On Wed, 2010-12-15 at 20:03 +0100, Nikola Pajkovsky wrote:
>> Signed-off-by: Nikola Pajkovsky<npajkovs(a)redhat.com>
>> ---
>> src/include/abrt_crash_dump.h | 1 +
>> src/include/report/dump_dir.h | 1 +
>> src/lib/crash_dump.c | 31 +++++++++++++++++++++++++++++++
>> src/lib/dump_dir.c | 41
+++++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 74 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/include/abrt_crash_dump.h b/src/include/abrt_crash_dump.h
>> index 9ecbf56..aa62000 100644
>> --- a/src/include/abrt_crash_dump.h
>> +++ b/src/include/abrt_crash_dump.h
>> @@ -70,6 +70,7 @@
>> // (a string with "\n" terminated event names)
>> #define CD_EVENTS "Events"
>>
>> +extern const char *abrt_known_files[];
> Can it be made static in crash_dump.c?
I suppose yes.
>> +char **dd_get_unknown_files(struct dump_dir *dd, const char **known_files);
> I don't see where do you use this function. I grepped the whole tree
> and there are no calls to it.
I don't but jiri will use it in gui/cli to list all possible files to
attach.
Nikola, don't write this function now, just make sure the files are
properly flagged when in memory representation is created. I'll
implement the get_attachments function in the client library...
Thanks,
J.