On Wed, 2010-06-30 at 11:11 +0200, Karel Klic wrote:
Hi,
I have created two small patches that change the remote crash handling:
- process crashes as unpackaged if the package is not found
- no gpg check
- new option BacktraceRemotes = yes|no in CCpp plugin to enable/disable
backtrace generation
Looks good. A few comments below.
remote = (remote_str.find('1') != std::string::npos);
Maybe use more readable construct: remote = (remote_str == "1");
(Two instances of this)
+# Generate backtrace for remote crashes
+BacktraceRemotes = no
Makes sense to be more verbose here. Clearer doc -> fewer confused
users -> less death threats in our emails.
Something like:
# Generate backtrace for crashes uploaded from remote machines.
# Note that for reliable backtrace generation, your local machine
# needs to have the crashed executable and all libraries it uses,
# and they need to be the same versions as on remote machines.
# If you cannot ensure that, it's better to set this option to "no"
BacktraceRemotes = no
--
vda