On 08/18/2010 04:27 AM, Denys Vlasenko wrote:
On Tue, 2010-08-17 at 15:25 +0200, Nikola Pajkovsky wrote:
> Signed-off-by: Nikola Pajkovsky<npajkovs(a)redhat.com>
> ---
> lib/plugins/RHTSupport.cpp | 79 ++++++++++++++++++++++++++-----------------
> lib/plugins/RHTSupport.h | 8 ++--
> 2 files changed, 52 insertions(+), 35 deletions(-)
Bug is here:
const map_plugin_settings_t& CReporterRHticket::GetSettings()
{
m_pSettings["URL"] = m_strata_url;
m_pSettings["Login"] = m_login;
m_pSettings["Password"] = m_password;
Assignment segfaults if right hand is a NULL pointer.
Good catch. fixed
+ m_pSettings["URL"] = (m_strata_url)? m_strata_url: "";
+ m_pSettings["Login"] = (m_login)? m_login: "";
+ m_pSettings["Password"] = (m_password)? m_password: "";