On Wed, 05 Jan 2011 11:58:32 +0100, Denys Vlasenko <dvlasenk(a)redhat.com> wrote:
On Wed, 2011-01-05 at 11:39 +0100, Nikola Pajkovsky wrote:
> > > --- a/lib/Utils/abrt_xmlrpc.cpp
> > > +++ b/lib/Utils/abrt_xmlrpc.cpp
> > > @@ -52,6 +52,15 @@ void abrt_xmlrpc_conn::new_xmlrpc_client(const char*
url, bool ssl_verify)
> > > * We do it in abrtd's main */
> > > /* xmlrpc_client_setup_global_const(&env); */
> > >
> > > + /* Bug related #666893 - Unable to make sense of XML-RPC response
from server
> > > + * By default, XML data from the network may be no larger than 512K.
> >
> > I understand the text above (propose small change: refer to the bug by
> > URL -
bugzilla.redhat.com/show_bug.cgi?id=666893 - so that people
> > do not need to guess *which bugzilla* it refers to), but next part ...
>
> will do
>
> > > + * Some client and server modules may fail to enforce this properly.
> >
> > I dont understand it. What "modules"?
>
> text was taken from xmlrpc-c/base.h
I see.
The comment should be understandable and useful for someone who reads
this code for the first time.
In this case, information "that some modules
_of curl_ do not properly check for the limit" is most likely not
interesting to the reader. I propose deleting it.
I did it, before you sent it ;)
> > > + * #define XMLRPC_XML_SIZE_LIMIT_DEFAULT
(512*1024)
> >
> > This in unclear too. I propose changing the above line to
> > "XMLRPC_XML_SIZE_LIMIT_DEFAULT is #defined to 512k in curl headers".
> >
> > > + *
> > > + * bug is long 733402 bytes for now, hope it will be enought
> >
> > Broken English. Propose: "Users reported trouble with 733402 byte long
> > responses, hope raising the limit to 2*512k is enough"
>
> ok
>
> > > + */
> > > + xmlrpc_limit_set(XMLRPC_XML_SIZE_LIMIT_ID, 2 *
XMLRPC_XML_SIZE_LIMIT_DEFAULT);
> > > +
> > > struct xmlrpc_curl_xportparms curlParms;
> > > memset(&curlParms, 0, sizeof(curlParms));
> > > /* curlParms.network_interface = NULL; - done by memset */
> >
>
> thanks
--
Nikola