On Fri, 2011-07-22 at 13:37 +0200, Miroslav Lichvar wrote:
+char *format_report_result(const struct report_result *result)
+{
+ const char *type_string;
+
+ switch (result->type)
+ {
+ case REPORT_RESULT_TYPE_URL:
+ type_string = "URL";
+ break;
+ case REPORT_RESULT_TYPE_MESSAGE:
+ type_string = "MSG";
+ break;
+ default:
+ assert(0);
+ }
+ return xasprintf("%s: TIME=%s %s=%s", result->event,
+ iso_date_string(&result->timestamp), type_string, result->data);
+}
Before this patch, the prefix indicated the type of report:
RHTSupport: <DATA>
meant "we reported it to RHTSsupport". This is needed to be able
to figure out what <DATA> means.
Now, you print event name instead. What will happen if reporting
is hooked, for example, to "post-create" event? It will be:
post-create: <DATA>
Now it is impossible to figure out, was it reported to RHTSupport?
Bugzilla? Sent by email?
--
vda