On 06/30/2010 01:45 PM, Denys Vlasenko wrote:
On Tue, 2010-06-29 at 17:03 +0200, Nikola Pajkovsky wrote:
> Signed-off-by: Nikola Pajkovsky<npajkovs(a)redhat.com>
> ---
> src/Daemon/Daemon.cpp | 25 +++++++++++++++----------
> src/Daemon/abrt.conf | 2 +-
> 2 files changed, 16 insertions(+), 11 deletions(-)
>
> diff --git a/src/Daemon/Daemon.cpp b/src/Daemon/Daemon.cpp
> index 6c61d4d..9667238 100644
> --- a/src/Daemon/Daemon.cpp
> +++ b/src/Daemon/Daemon.cpp
> @@ -506,17 +506,22 @@ static gboolean handle_inotify_cb(GIOChannel *gio, GIOCondition
condition, gpoin
> }
> log("Directory '%s' creation detected", name);
>
> - std::string worst_dir;
> - while (g_settings_nMaxCrashReportsSize> 0
> -&& get_dirsize_find_largest_dir(DEBUG_DUMPS_DIR,&worst_dir, name) /
(1024*1024)>= g_settings_nMaxCrashReportsSize
> -&& worst_dir != ""
> - ) {
...
> }
> + else
> + log("MaxReportsSize is unlimited");
I think logging "MaxReportsSize is unlimited" is not necessary -
admin likely knows that he set it this way.
Looks good, please apply to git.
thx, I will remove it. This message should be more clever to be useful. Something like
"MaxReportsSize is unlimited and disk space is %d".