Repository :
http://git.fedorahosted.org/cgit/copr.git
On branch : master
---------------------------------------------------------------
commit cddbf44de7f8f05bf3fcedc58f7d1dde567948d3
Author: Valentin Gologuzov <vgologuz(a)redhat.com>
Date: Mon Mar 30 14:23:59 2015 +0200
[frontend] Bug 1206562 - Cannot delete Copr because it incorrectly thinks there are
unfinished builds. Solution: `failed` but unfinished (ended_on is null) builds should be
rescheduled.
---------------------------------------------------------------
.../coprs_frontend/coprs/logic/builds_logic.py | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/logic/builds_logic.py
b/frontend/coprs_frontend/coprs/logic/builds_logic.py
index 2712e48..b088ef9 100644
--- a/frontend/coprs_frontend/coprs/logic/builds_logic.py
+++ b/frontend/coprs_frontend/coprs/logic/builds_logic.py
@@ -59,7 +59,8 @@ class BuildsLogic(object):
models.BuildChroot.status == helpers.StatusEnum("pending"),
models.BuildChroot.status == helpers.StatusEnum("starting"),
and_(
- models.BuildChroot.status == helpers.StatusEnum("running"),
+ models.BuildChroot.status.in_([
+ helpers.StatusEnum("running"),
helpers.StatusEnum("failed")]),
models.Build.started_on < int(time.time() - 1.1 * MAX_BUILD_TIMEOUT),
models.Build.ended_on.is_(None)
)
@@ -218,11 +219,12 @@ class BuildsLogic(object):
"""
if not user.can_build_in(build.copr):
raise exceptions.InsufficientRightsException(
- "You are not allowed to delete this build.")
+ "You are not allowed to delete build `{}`.".format(build.id))
if not build.deletable:
+ # from celery.contrib import rdb; rdb.set_trace()
raise exceptions.ActionInProgressException(
- "You can not delete build which is not finished.",
+ "You can not delete build `{}` which is not
finished.".format(build.id),
"Unfinished build")
# Only failed, finished, succeeded get here.