Repository :
http://git.fedorahosted.org/cgit/copr.git
On branch : master
---------------------------------------------------------------
commit 13c606f72e6aba4ed81b3ce9077754372cba3119
Author: Jakub Kadl����k <jkadlcik(a)redhat.com>
Date: Mon Feb 8 14:21:21 2016 +0100
[frontend] always print button for package rebuild
Disabled links does not work in all browsers (i.e. Konqueror) and
it can be confusing. Rather redirect to package settings in case of
missing default source.
---------------------------------------------------------------
.../templates/coprs/detail/_packages_table.html | 4 ++--
.../coprs/templates/coprs/detail/package.html | 2 --
.../coprs/views/coprs_ns/coprs_packages.py | 4 ++++
3 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/templates/coprs/detail/_packages_table.html
b/frontend/coprs_frontend/coprs/templates/coprs/detail/_packages_table.html
index f725ee6..184e041 100644
--- a/frontend/coprs_frontend/coprs/templates/coprs/detail/_packages_table.html
+++ b/frontend/coprs_frontend/coprs/templates/coprs/detail/_packages_table.html
@@ -51,9 +51,9 @@
<td>
{% if g.user and g.user.can_build_in(copr) %}
<a class="btn btn-default btn-sm"
- {% if not package.source_type %}disabled="disabled"{% endif %}
href="{{ copr_url('coprs_ns.copr_rebuild_package', copr,
package_name=package.name) }}">
- <span class="pficon pficon-restart"></span> Rebuild
</a>
+ <span class="{% if package.source_type %}pficon pficon-restart{% else
%}fa fa-wrench{% endif %}"></span> Rebuild
+ </a>
{% else %}
-
{% endif %}
diff --git a/frontend/coprs_frontend/coprs/templates/coprs/detail/package.html
b/frontend/coprs_frontend/coprs/templates/coprs/detail/package.html
index 8f7f088..e5cc5a3 100644
--- a/frontend/coprs_frontend/coprs/templates/coprs/detail/package.html
+++ b/frontend/coprs_frontend/coprs/templates/coprs/detail/package.html
@@ -18,11 +18,9 @@
{% block detail_body %}
-{% if package.source_type %}
<a class="btn btn-default pull-right button-build-action" href="{{
copr_url('coprs_ns.copr_rebuild_package', copr, package_name=package.name)
}}">
<span class="pficon pficon-restart"></span> Rebuild
</a>
-{% endif %}
<h2 class="page-title"> Package: {{ package.name }} </h2>
diff --git a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_packages.py
b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_packages.py
index 8036387..9ca1ed3 100644
--- a/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_packages.py
+++ b/frontend/coprs_frontend/coprs/views/coprs_ns/coprs_packages.py
@@ -47,6 +47,10 @@ def copr_rebuild_package(copr, package_name):
form = forms.BuildFormMockFactory
f = render_add_build_mock
view_suffix = "_mock"
+ else:
+ flask.flash("Package {} has not the default source which is required for
rebuild. Please configure some source"
+ .format(package_name, copr.full_name))
+ return flask.redirect(copr_url("coprs_ns.copr_edit_package", copr,
package_name=package_name))
form = form(copr.active_chroots)(data=data)
return f(copr, form, view="coprs_ns.copr_new_build" + view_suffix,
package=package)