[copr] master: W: 10, 0: Unused BackendLogic imported from coprs.logic.backend_logic (unused-import) (1bc37fa)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 1bc37fa5536058c7bd37f38423b1e69bf7b21452
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 13:50:00 2015 +0100
W: 10, 0: Unused BackendLogic imported from coprs.logic.backend_logic (unused-import)
>---------------------------------------------------------------
.../coprs/views/backend_ns/backend_general.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py b/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py
index 3b3b2f0..bb6712c 100644
--- a/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py
+++ b/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py
@@ -7,7 +7,6 @@ from coprs import db, app
from coprs import helpers
from coprs.helpers import StatusEnum
from coprs.logic import actions_logic
-from coprs.logic.backend_logic import BackendLogic
from coprs.logic.builds_logic import BuildsLogic
from coprs.logic.complex_logic import ComplexLogic
from coprs.logic.coprs_logic import CoprChrootsLogic
8 years, 6 months
[copr] master: unused variable repo_name (73e0c26)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 73e0c26162b1781dfb7e1709e6f682b4c40bd4d0
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 13:55:44 2015 +0100
unused variable repo_name
>---------------------------------------------------------------
.../coprs/views/backend_ns/backend_general.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py b/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py
index 88e847a..f7338bd 100644
--- a/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py
+++ b/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py
@@ -75,7 +75,6 @@ def dist_git_upload_completed():
# Is it OK?
if "git_hash" in flask.request.json and "repo_name" in flask.request.json:
git_hash = flask.request.json["git_hash"]
- repo_name = flask.request.json["repo_name"]
pkg_name = flask.request.json["pkg_name"]
pkg_version = flask.request.json["pkg_version"]
8 years, 6 months
[copr] master: W: 17, 0: Unused ServerError imported from exceptions (unused-import) (ed681b3)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit ed681b31eede77c92321ea05ed98b2a3c32164a4
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 13:45:58 2015 +0100
W: 17, 0: Unused ServerError imported from exceptions (unused-import)
>---------------------------------------------------------------
.../coprs/rest_api/resources/project_chroot.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
index 681b846..ecb5b99 100644
--- a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
+++ b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
@@ -15,7 +15,7 @@ from ...logic.coprs_logic import MockChrootsLogic, CoprChrootsLogic
from ...exceptions import InsufficientRightsException, MalformedArgumentException
from ..exceptions import AccessForbidden, MalformedRequest, \
- ObjectAlreadyExists, ServerError, ObjectNotFoundError
+ ObjectAlreadyExists, ObjectNotFoundError
from ..common import rest_api_auth_required, render_copr_chroot, get_project_safe
from ..schemas import CoprChrootSchema, CoprChrootCreateSchema
from ..util import get_one_safe, mm_deserialize
8 years, 6 months
[copr] master: E:146, 0: function already defined line 139 (function-redefined) (1537fdc)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 1537fdcf919fa041bd00bf9c147f43a31ee14885
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:08:39 2015 +0100
E:146, 0: function already defined line 139 (function-redefined)
>---------------------------------------------------------------
frontend/coprs_frontend/coprs/filters.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/filters.py b/frontend/coprs_frontend/coprs/filters.py
index c022603..1286185 100644
--- a/frontend/coprs_frontend/coprs/filters.py
+++ b/frontend/coprs_frontend/coprs/filters.py
@@ -143,7 +143,7 @@ def parse_package_name(pkg):
@app.template_filter("basename")
-def parse_package_name(pkg):
+def parse_basename(pkg):
if pkg is not None:
return os.path.basename(pkg)
return pkg
8 years, 6 months
[copr] master: C:115, 0: Wrong continued indentation. (a5db15c)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit a5db15ca6bd85ea060b278af5a3e0186cfacdf08
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:01:07 2015 +0100
C:115, 0: Wrong continued indentation.
>---------------------------------------------------------------
frontend/coprs_frontend/coprs/helpers.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/helpers.py b/frontend/coprs_frontend/coprs/helpers.py
index 2731f3b..1584889 100644
--- a/frontend/coprs_frontend/coprs/helpers.py
+++ b/frontend/coprs_frontend/coprs/helpers.py
@@ -112,7 +112,7 @@ class FailTypeEnum(with_metaclass(EnumType, object)):
"git_wrong_directory": 32,
"git_checkout_error": 33,
"srpm_build_error": 34,
- }
+ }
class JSONEncodedDict(TypeDecorator):
8 years, 6 months
[copr] master: W: 12, 0: Unused app imported from coprs (unused-import) (a02c599)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit a02c599e858146b7303cfbc7c57be131312f2077
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:15:24 2015 +0100
W: 12, 0: Unused app imported from coprs (unused-import)
>---------------------------------------------------------------
.../coprs/views/api_ns/api_general.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
index 727bbde..59edb48 100644
--- a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
+++ b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
@@ -6,7 +6,6 @@ import flask
from werkzeug import secure_filename
-from coprs import app
from coprs import db
from coprs import exceptions
from coprs import forms
8 years, 6 months
[copr] master: W: 4, 0: Unused import os (unused-import) (c39fe28)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit c39fe28eac13562347bf4216020980b1cbd7e1f3
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 13:50:25 2015 +0100
W: 4, 0: Unused import os (unused-import)
>---------------------------------------------------------------
.../coprs/views/backend_ns/backend_general.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py b/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py
index bb6712c..88e847a 100644
--- a/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py
+++ b/frontend/coprs_frontend/coprs/views/backend_ns/backend_general.py
@@ -1,7 +1,6 @@
import flask
import sys
import time
-import os
from coprs import db, app
from coprs import helpers
8 years, 6 months
[copr] master: R: 87, 4: Method could be a function (no-self-use) (bba333b)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit bba333b3d6182cee26a18e1d0f7d2ff48cbd1062
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 13:45:01 2015 +0100
R: 87, 4: Method could be a function (no-self-use)
>---------------------------------------------------------------
.../coprs/rest_api/resources/project_chroot.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
index 6ce45f9..4f1ebb2 100644
--- a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
+++ b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
@@ -85,8 +85,9 @@ class ProjectChrootR(Resource):
return render_copr_chroot(chroot)
+ @classmethod
@rest_api_auth_required
- def delete(self, project_id, name):
+ def delete(cls, project_id, name):
project = get_project_safe(project_id)
chroot = CoprChrootsLogic.get_by_name_safe(project, name)
8 years, 6 months
[copr] master: W: 21, 0: Unused UsersLogic imported from coprs.logic.users_logic (unused-import) (b2f5f07)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit b2f5f0755af803f2759ae99db447aef646f2892a
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:15:50 2015 +0100
W: 21, 0: Unused UsersLogic imported from coprs.logic.users_logic (unused-import)
>---------------------------------------------------------------
.../coprs/views/api_ns/api_general.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
index 59edb48..a504a8f 100644
--- a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
+++ b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
@@ -14,7 +14,6 @@ from coprs.helpers import fix_protocol_for_backend
from coprs.logic.api_logic import MonitorWrapper
from coprs.logic.builds_logic import BuildsLogic
from coprs.logic.complex_logic import ComplexLogic
-from coprs.logic.users_logic import UsersLogic
from coprs.views.misc import login_required, api_login_required
8 years, 6 months
[copr] master: R: 26, 4: Method could be a function (no-self-use) (eebb52d)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit eebb52dcecc762b624b4cedd60993c24c3c36f9a
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 13:42:02 2015 +0100
R: 26, 4: Method could be a function (no-self-use)
>---------------------------------------------------------------
.../coprs/rest_api/resources/project_chroot.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
index 3c67b5e..b79792d 100644
--- a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
+++ b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
@@ -23,7 +23,8 @@ from ..util import get_one_safe, mm_deserialize
class ProjectChrootListR(Resource):
- def get(self, project_id):
+ @classmethod
+ def get(cls, project_id):
project = get_project_safe(project_id)
return {
8 years, 6 months