[copr] master: W: 5, 0: Unused import shutil (unused-import) (f3a2058)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit f3a2058686f6648c0f3f9a4844890cc2289f52e4
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:13:50 2015 +0100
W: 5, 0: Unused import shutil (unused-import)
>---------------------------------------------------------------
.../coprs/views/api_ns/api_general.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
index 7c2352c..bdc1017 100644
--- a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
+++ b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
@@ -2,7 +2,6 @@ import base64
import datetime
from functools import wraps
import os
-import shutil
import tempfile
import json
import flask
8 years, 6 months
[copr] master: unused import CoprChrootsLogic (3913a6d)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 3913a6dbb6378b8da2142c70c69e44b4aa59f82c
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:21:09 2015 +0100
unused import CoprChrootsLogic
>---------------------------------------------------------------
.../coprs/views/api_ns/api_general.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
index a504a8f..df4457a 100644
--- a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
+++ b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
@@ -21,7 +21,7 @@ from coprs.views.api_ns import api_ns
from coprs.logic import builds_logic
from coprs.logic import coprs_logic
-from coprs.logic.coprs_logic import CoprsLogic, CoprChrootsLogic
+from coprs.logic.coprs_logic import CoprsLogic
from coprs.exceptions import (ActionInProgressException,
InsufficientRightsException,
8 years, 6 months
[copr] master: W: 7, 25: Redefining built-in file (redefined-builtin) (98ec2c2)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 98ec2c226ae461630d80421e4ce5141e278cad22
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 13:47:59 2015 +0100
W: 7,25: Redefining built-in file (redefined-builtin)
>---------------------------------------------------------------
.../coprs/views/tmp_ns/tmp_general.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/tmp_ns/tmp_general.py b/frontend/coprs_frontend/coprs/views/tmp_ns/tmp_general.py
index 8fa11ee..4571447 100644
--- a/frontend/coprs_frontend/coprs/views/tmp_ns/tmp_general.py
+++ b/frontend/coprs_frontend/coprs/views/tmp_ns/tmp_general.py
@@ -4,6 +4,6 @@ from coprs.views.tmp_ns import tmp_ns
from coprs import app
@tmp_ns.route("/<directory>/<file>")
-def give_srpm(directory, file):
+def give_srpm(directory, file_path):
path = os.path.join(app.config["SRPM_STORAGE_DIR"], directory)
- return flask.send_from_directory(path, file)
+ return flask.send_from_directory(path, file_path)
8 years, 6 months
[copr] master: W: 6, 0: Unused import tempfile (unused-import) (b4eae28)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit b4eae2873025b377efa798f0a09b2cdfab3849a1
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:14:08 2015 +0100
W: 6, 0: Unused import tempfile (unused-import)
>---------------------------------------------------------------
.../coprs/views/api_ns/api_general.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
index bdc1017..89bfd43 100644
--- a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
+++ b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
@@ -2,7 +2,6 @@ import base64
import datetime
from functools import wraps
import os
-import tempfile
import json
import flask
8 years, 6 months
[copr] master: R: 40, 4: Method could be a function (no-self-use) (d2f6cc1)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit d2f6cc14720cd32f427cf476a58a65e0e9ce1544
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 13:44:32 2015 +0100
R: 40, 4: Method could be a function (no-self-use)
>---------------------------------------------------------------
.../coprs/rest_api/resources/project_chroot.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
index b79792d..6ce45f9 100644
--- a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
+++ b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
@@ -37,8 +37,9 @@ class ProjectChrootListR(Resource):
}
}
+ @classmethod
@rest_api_auth_required
- def post(self, project_id):
+ def post(cls, project_id):
project = get_project_safe(project_id)
chroot_data = mm_deserialize(CoprChrootCreateSchema(),
8 years, 6 months
[copr] master: W: 14, 0: Unused CoprsLogic imported from logic.coprs_logic (unused-import) (5891977)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 58919771b6996386400dd5ee4104cbfcf808b921
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 13:45:26 2015 +0100
W: 14, 0: Unused CoprsLogic imported from logic.coprs_logic (unused-import)
>---------------------------------------------------------------
.../coprs/rest_api/resources/project_chroot.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
index 4f1ebb2..681b846 100644
--- a/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
+++ b/frontend/coprs_frontend/coprs/rest_api/resources/project_chroot.py
@@ -11,7 +11,7 @@ from flask_restful import Resource
from sqlalchemy.exc import IntegrityError
from ... import db
-from ...logic.coprs_logic import MockChrootsLogic, CoprChrootsLogic, CoprsLogic
+from ...logic.coprs_logic import MockChrootsLogic, CoprChrootsLogic
from ...exceptions import InsufficientRightsException, MalformedArgumentException
from ..exceptions import AccessForbidden, MalformedRequest, \
8 years, 6 months
[copr] master: E:170, 0: function already defined line 153 (function-redefined) (69a798a)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 69a798a6a9cfda18ff78d703186e07ddda0d1dbb
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:10:43 2015 +0100
E:170, 0: function already defined line 153 (function-redefined)
>---------------------------------------------------------------
frontend/coprs_frontend/coprs/filters.py | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/filters.py b/frontend/coprs_frontend/coprs/filters.py
index 1286185..ffe4599 100644
--- a/frontend/coprs_frontend/coprs/filters.py
+++ b/frontend/coprs_frontend/coprs/filters.py
@@ -167,8 +167,7 @@ def build_state_decoration(state):
@app.template_filter("build_source_description")
-def build_state_decoration(state):
-
+def build_source_description(state):
description_map = {
"unset": "No default source",
"srpm_link": "External link with SRPM",
8 years, 6 months
[copr] master: W: 1, 0: Unused wraps imported from functools (unused-import) (77a9223)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 77a9223ce182593e0be73f95a80f0f55af085705
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:06:36 2015 +0100
W: 1, 0: Unused wraps imported from functools (unused-import)
>---------------------------------------------------------------
frontend/coprs_frontend/coprs/helpers.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/helpers.py b/frontend/coprs_frontend/coprs/helpers.py
index 1584889..e063b58 100644
--- a/frontend/coprs_frontend/coprs/helpers.py
+++ b/frontend/coprs_frontend/coprs/helpers.py
@@ -1,4 +1,3 @@
-from functools import wraps
import math
import random
import string
8 years, 6 months
[copr] master: W: 7, 0: Unused import json (unused-import) (444ab25)
by Miroslav Suchý
Repository : http://git.fedorahosted.org/cgit/copr.git
On branch : master
>---------------------------------------------------------------
commit 444ab25f662806ab825a027ab1f1c0b9efc0ce18
Author: Miroslav Suchý <msuchy(a)redhat.com>
Date: Fri Nov 13 14:14:46 2015 +0100
W: 7, 0: Unused import json (unused-import)
>---------------------------------------------------------------
.../coprs/views/api_ns/api_general.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
index 89bfd43..727bbde 100644
--- a/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
+++ b/frontend/coprs_frontend/coprs/views/api_ns/api_general.py
@@ -2,7 +2,6 @@ import base64
import datetime
from functools import wraps
import os
-import json
import flask
from werkzeug import secure_filename
8 years, 6 months