https://bugzilla.redhat.com/show_bug.cgi?id=1628914
--- Comment #5 from Debarshi Ray <debarshir(a)redhat.com> ---
(In reply to Tomas Tomecek from comment #3)
I have updated
https://rishi.fedorapeople.org/fedora-toolbox.tar.xz as per the
following changes:
(In reply to Debarshi Ray from comment #2)
> You mean that the docker:// prefix should be removed? It didn't strike me as
> a problem because it builds locally with 'buildah bud --tag
> fedora-toolbox:28 .', but I can definitely remove it.
Yes, the `docker://` prefix.
I used docker to build it -- Fedora OSBS doesn't utilize buildah (yet?).
Ok, I see. Removed.
So please state it then in the usage label: 'This container image
is meant
to be used with fedora-toolbox command.'
Added a 'usage' label as suggested.
As I said: the container images are meant to be tested and provided
as a
unit. When you perform an update inside, you change that unit and make it
really hard for the vendor to provide support for such image. If you want
the newest packages, you should wait for an updated base image (this is the
best practices which I can't find any documentation for).
This was really just a heads-up, feel free to leave it as it is: in the end,
it's your image, not mine :)
Ok, removed the 'dnf -y upgrade'.
Rishi, I might be off the Internet for several weeks. I don't
want you to be
blocked on me, hence granting review+. Please, just update the `FROM` line
and usage label and we should be good.
Thanks for the review, Tomas!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OdtIWbDC8B&a=cc_unsubscribe