On Wed, 2018-12-05 at 15:06 -0500, Johnny Bieren wrote:
On Wed, Dec 5, 2018 at 2:38 PM Adam Williamson
<adamwill(a)fedoraproject.org>
wrote:
> I had reason today to go poking through the ResultsDB fedmsg history:
>
>
https://apps.fedoraproject.org/datagrepper/raw?category=resultsdb
>
> doing that makes it apparent that the pipeline is kinda flooding
> ResultsDB with "test results" that seem to be nothing more than "the
> pipeline decided not to test this package". Something like 99% of
> pipeline results appear to be of this type - either
> "ci.pipeline.allpackages-build.package.ignored" or
> "ci.pipeline.package.ignore". There've been 20
ci.pipeline.allpackages-
> build.package.ignored results filed in just the last 7 minutes, for
> instance, and it seems like there's a more or less constant stream of
> them.
>
> Are these results really necessary or useful? ResultsDB is built to
> handle the load, I think, and my use case of poking through fedmsg
> history looking for messages from the pipeline *actually doing
> something* is not a super common one, but still, if this isn't really
> necessary, it seems like it might be a good idea to just not do it.
>
> (Also, on the topic of why there are two topics - is one from the new
> pipeline and one from the old? Do we still need the old pipeline
> running?)
>
I'll let Bruno or Miroslav speak to whether we can turn off the .ignore
messages,
To be clear, I can see why the pipeline might want to *emit a fedmsg on
its own topic* saying that it ignored a package. What doesn't seem to
be necessary is to *submit a result to ResultsDB* which looks like
this:
https://taskotron.fedoraproject.org/resultsdb/results/25608385
it's kind of a bizarre result, because it sort of looks like a test
passed, but really it just means...there was no test at all. Why submit
a 'test result' for a case where nothing was tested?
I mentioned fedmsgs because I was looking at the fedmsgs *emitted by
ResultsDB itself* when a result is created (as that's what greenwave is
using - I was fixing stuff in greenwave). But I'm not suggesting the
pipeline shouldn't emit messages *on its own topic* when it ignores
something, just that it shouldn't submit a "test result" to ResultsDB
when it does that.
but to answer your last question, yes, there are two topics
because one is the new pipeline and one is the old (atomic) pipeline. The
old (atomic) pipeline has not been updated for anything past Fedora 27, so
it may be the case that the old one can stop running.
F27 is EOL as of now, so it seems like that might be the case, yeah.
Thanks!
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net