----- Original Message -----
From: "Brian C. Lane" <bcl(a)redhat.com>
To: anaconda-patches(a)lists.fedorahosted.org
Sent: Thursday, December 4, 2014 1:19:59 PM
Subject: Re: [blivet:rhel7:master 1/3] Change allow_degraded_mdraid flag
to allow_imperfect_devices (#1090009)
On Wed, Dec 03, 2014 at 02:33:06PM -0500, mulhern wrote:
> self.update_from_boot_cmdline()
> - self.allow_degraded_mdraid = True
> + self.allow_imperfect_devices = True
>
> def get_boot_cmdline(self):
> buf = open("/proc/cmdline").read().strip()
> @@ -101,7 +101,7 @@ class Flags(object):
> self.gpt = anaconda_flags.gpt
>
> self.multipath_friendly_names = anaconda_flags.mpathFriendlyNames
> - self.allow_degraded_mdraid = anaconda_flags.rescue_mode
> + self.allow_imperfect_devices = anaconda_flags.rescue_mode
>
> self.ibft = anaconda_flags.ibft
> self.dmraid = anaconda_flags.dmraid
I'd go the other direction and make it default to False. Users that want
to allow degraded devices can set it themselves.
True was dlehman's recommendation originally. I have no strong opinion
on which is best and am happy to change if that is agreeable.
I'd also make anaconda handle setting it instead of adding another
use of anaconda flags in blivet. Hopefully at some point we can remove
all of these and have anaconda setup blivet like every other user of the
library.
Tis a consummation devoutly to be wished. But I think that's
really beyond the scope of this patch.
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA
(PST8PDT)
_______________________________________________
anaconda-patches mailing list
anaconda-patches(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches