On Fri, 2013-05-24 at 12:20 -0500, David Lehman wrote:
On Fri, 2013-05-24 at 19:01 +0200, Vratislav Podzimek wrote:
> Also invoke the callback for such event (if any).
>
> Signed-off-by: Vratislav Podzimek <vpodzime(a)redhat.com>
Good idea. The blivet set looks good in general, but I have a few
comments:
1. MINIMAL_ENTROPY should go into devicelibs.crypto instead of
formats.luks
2. consider moving get_current_entropy into devicelibs.crypto
Will do, thanks for
the tips. I was thinking about where to puth these
things, but I've overseen the devicelibs.crypto module.
3. it would be nice if there were some abstraction of the callback
handling in the DeviceAction classes
Yeah, I agree with that. But I'm not
sure there is any nice way how to
do it. I was thinking about all actions calling their "pre" and
"post"
callbacks with names derived from their class names, but that would be a
hack, I think. Any better suggestions? Maybe adding some _pre_callback
and _post_callback class attributes holding the names of the callbacks
to the actions?
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic