----- Original Message -----
From: "David Lehman" <dlehman(a)redhat.com>
To: anaconda-patches(a)lists.fedorahosted.org
Sent: Wednesday, June 25, 2014 9:31:25 AM
Subject: Re: [anaconda:master] Patches to allow /boot to be RAID1 with EFI (#791136)
On 06/24/2014 02:49 PM, mulhern wrote:
> Resolves: rhbz#791136
>
> Signed-off-by: mulhern <amulhern(a)redhat.com>
> ---
> pyanaconda/bootloader.py | 20 ++++++++++----------
> pyanaconda/storage_utils.py | 2 +-
> pyanaconda/ui/gui/spokes/custom.py | 9 +++++----
> 3 files changed, 16 insertions(+), 15 deletions(-)
>
> diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
> index c0e34da..41a906f 100644
> --- a/pyanaconda/bootloader.py
> +++ b/pyanaconda/bootloader.py
> @@ -1713,16 +1713,9 @@ class EFIGRUB(GRUB2):
> ret = self._config_dir.replace('efi/', '')
> return "\\" + ret.replace('/', '\\')
>
> - def add_efi_boot_target(self):
> - if self.stage1_device.type == "partition":
> - boot_disk = self.stage1_device.disk
> - boot_part_num = self.stage1_device.partedPartition.number
> - elif self.stage1_device.type == "mdarray":
> - # FIXME: I'm just guessing here. This probably needs the full
> - # treatment, ie: multiple targets for each member.
> - boot_disk = self.stage1_device.parents[0].disk
> - boot_part_num =
> self.stage1_device.parents[0].partedPartition.number
> - boot_part_num = str(boot_part_num)
> + def _add_single_efi_boot_target(self, disk):
> + boot_disk = disk.disk
> + boot_part_num = disk.partedPartition.number
Calling the partition "disk" is pretty confusing. It would be much
clearer if it were named "partition" instead. Otherwise this and the
blivet set look good to me.
David
Fixed. Also fixed the bug number which was 788313 not 791136.
- mulhern