On Fri, Dec 20, 2013 at 11:59:59AM -0600, David Lehman wrote:
Size essentially stores sizes in bytes and provides methods for
conversion between various units.
All sizes originating from within blivet are based on binary prefixes
except where required to interface with other tools (see ntfsresize).
---
I really like how this looks. Makes things much more readable and should
eliminate all those pesky float rounding problems.
comments:
1. There are several places where spec is used instead of en_spec for
constants.
2. inconsistent use of spaces between the size and the units, I think
they are more readable with spaces.
3. getPossiblePhysicalExtents dropped floor from the args. It is still
used in the function.
4. In FileDevice._create buf is undefined and zero unused. Or we could
just use dd for this like we do in wipe.
That's all I spotted. Now I need a nap :)
--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)