On 03/11/2013 04:36 PM, Chris Lumens wrote:
> @@ -1147,6 +1151,8 @@ class NetworkSpoke(NormalSpoke):
> msg = _("Wireless connected to %s" % info)
> elif type == NetworkManager.DeviceType.BOND:
> msg = _("Bond %s (%s) connected" % (name,
",".join(info)))
> + if type == NetworkManager.DeviceType.VLAN:
> + msg = _("Vlan %s (%s, ID %s) connected") % (name,
info[0], info[1])
> else:
> devlist = []
> for name, type, info in ac:
For complex strings like this (and I should have pointed it out on
previous patches, too), it really helps translators if you do it like
so:
msg = _("Vlan %(name)s (%(whatever1)s, ID %(whatever2)s) connected") % \
{"name": name, "whatever1": info[0], "whatever2":
info[2]}
That gives them more context to know how the pieces can be moved around
when converting them to other languages.
- Chris
Thank you for reminding me, I think you've already mentioned
it in some previous review of my patches (also the %s parameters
inside _()). Hopefully I'll remember it for next time.
Radek