From: "Vratislav Podzimek" <vpodzime(a)redhat.com>
To: "anaconda patch review" <anaconda-patches(a)lists.fedorahosted.org>
Sent: Wednesday, October 1, 2014 10:05:38 AM
Subject: Re: [blivet:master 1/2] Further abstract loopbackedtestcase on block_size.
On Wed, 2014-10-01 at 09:46 -0400, Anne Mulhern wrote:
>
>
>
> ----- Original Message -----
> > From: "Vratislav Podzimek" <vpodzime(a)redhat.com>
> > To: "anaconda patch review"
<anaconda-patches(a)lists.fedorahosted.org>
> > Sent: Wednesday, October 1, 2014 5:47:46 AM
> > Subject: Re: [blivet:master 1/2] Further abstract loopbackedtestcase on
> > block_size.
> >
> > On Tue, 2014-09-30 at 09:02 -0400, mulhern wrote:
>
> <-- SNIP -->
>
> > > @@ -67,33 +69,38 @@ def getFreeLoopDev():
> > > @unittest.skipUnless(os.geteuid() == 0, "requires root
privileges")
> > > class LoopBackedTestCase(unittest.TestCase):
> > >
> > > - DEFAULT_STORE_SIZE = 102400
> > > + DEFAULT_BLOCK_SIZE = Size(1024)
> > I think 'Size("1 KiB")' would be nicer here.
> >
>
> I think so, too.
>
> Can we think about humanReadable() one last time? By default, it displays
> "1 KiB" as "1024 B".
> I would prefer "1 KiB" and I think most people would.
>
> Trickier is:
>
> Which is better "1044 B" or "1.02 KiB"?
>
> What about "9.99 KiB" vs. "10229 B"?
I like the old rule that less than 10 of something means that users will
probably care about small differences, more than 10 means less than 0.01
is not that important difference. With B and KiB it gets a bit weird,
but we hardly ever show such values. And if we really encounter
something that is smaller than 10 KiB I think it is okay to show the
number of bytes.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
_______________________________________________
anaconda-patches mailing list
anaconda-patches(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
B and KiBs behave the same as anything else, really.
I can rephrase as:
Which is better "1044 Kib" or "1.02 MiB",
"1 GiB" or "1024 Mib",
"9.99 MiB" or "10229 KiB"?
Does putting the values in larger units make any difference?
- mulhern