On Mon, 2015-06-29 at 08:40 -0500, David Lehman wrote:
On 06/29/2015 08:10 AM, Vratislav Podzimek wrote:
> When trying to find existing installations we setup and mount devices (to check
> if they have /etc/fstab). Setting a device up results in its parents being setup
> too (recursively) so when tearing the device down we should also tear its
> parents (recursively) down so that they are not left activated as that could
> cause problems later (as for example in the bug where a thin pool was
> activated/setup on setup of a thin LV and never deactivated/torn down).
It would be nicer to do one full teardown at the exit point of
findExistingInstallations instead of this, since this could cause a
significant amount of activity for some setups (esp. lvm on luks and/or
md).
I didn't notice any while testing, but doing one full teardown is
definitely better. Sending v2 of this patch. Thanks!
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic