From: "Vratislav Podzimek" <vpodzime(a)redhat.com>
To: "anaconda patch review" <anaconda-patches(a)lists.fedorahosted.org>
Sent: Friday, March 21, 2014 3:58:36 AM
Subject: Re: [blivet] support for container member set management
On Thu, 2014-03-20 at 12:14 -0500, David Lehman wrote:
> This adds the ability to add/remove members from a volume group,
> md array, or btrfs volume. It adds a ContainerDevice class to
> provide the interfaces.
>
> This isn't expected to impact anaconda at all.
>
> blivet/deviceaction.py | 198 +++++++++++++--
> blivet/devicefactory.py | 26 +-
> blivet/devicelibs/btrfs.py | 14 +-
> blivet/devicelibs/lvm.py | 57 ++++-
> blivet/devicelibs/mdraid.py | 61 ++++-
> blivet/devices.py | 592
> +++++++++++++++++++++++---------------------
> blivet/devicetree.py | 21 +-
> blivet/formats/fs.py | 4 +-
> tests/action_test.py | 122 +++++++++
> tests/devices_test.py | 88 ++++---
> 10 files changed, 816 insertions(+), 367 deletions(-)
Other than those inline comments/questions these all look good to me.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic
_______________________________________________
anaconda-patches mailing list
anaconda-patches(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches