On 12/18/2013 11:04 AM, Samantha N. Bueno wrote:
This gives s390x users the ability to add a zFCP device for use
during
installation. Even if a device is "offline", if the correct credentials
are entered, the device will be detected and turned "online" for use.
Resolves: rhbz#994423
---
pyanaconda/ui/gui/spokes/advstorage/zfcp.glade | 447 +++++++++++++++++++++++++
pyanaconda/ui/gui/spokes/advstorage/zfcp.py | 151 +++++++++
2 files changed, 598 insertions(+)
create mode 100644 pyanaconda/ui/gui/spokes/advstorage/zfcp.glade
create mode 100644 pyanaconda/ui/gui/spokes/advstorage/zfcp.py
diff --git a/pyanaconda/ui/gui/spokes/advstorage/zfcp.glade
b/pyanaconda/ui/gui/spokes/advstorage/zfcp.glade
new file mode 100644
index 0000000..0b3465b
--- /dev/null
+++ b/pyanaconda/ui/gui/spokes/advstorage/zfcp.glade
The glade file needs to go in
POTFILES.in
+ <child>
+ <object class="GtkLabel" id="label7">
+ <property name="visible">True</property>
+ <property
name="can_focus">False</property>
+ <property name="xalign">0</property>
+ <property name="label" translatable="yes"
context="GUI|Advanced Storage|zFCP">WWPN:</property>
+ <property
name="use_underline">True</property>
+ <property
name="mnemonic_widget">wwpnEntry</property>
+ </object>
WWPN should have an underline for a
shortcut.
+ <child>
+ <object class="GtkLabel" id="label2">
+ <property name="visible">True</property>
+ <property
name="can_focus">False</property>
+ <property name="xalign">0</property>
+ <property name="label" translatable="yes"
context="GUI|Advanced Storage|zFCP">LUN:</property>
+ <property
name="use_underline">True</property>
+ <property
name="mnemonic_widget">lunEntry</property>
+ </object>
Same here, no underline
+ <packing>
+ <property name="left_attach">0</property>
+ <property name="top_attach">3</property>
+ <property name="width">1</property>
+ <property name="height">1</property>
+ </packing>
+ </child>
+ <child>
+ <object class="GtkEntry" id="lunEntry">
+ <property name="visible">True</property>
+ <property
name="can_focus">True</property>
+ <property name="hexpand">True</property>
+ <property
name="invisible_char">●</property>
+ <property
name="invisible_char_set">True</property>
+ </object>
Is there a reason this has the invisible
char stuff set? If it got
pulled as defaults, whatever, but if it's actually supposed to be
treated as a password-style entry then visible should be set to False.
This is the only I saw with invisible_char_set set, so just wondering if
that meant something.
And a cautionary note: the translations contexts aren't going to work on
rhel7-branch, so be sure not to include them there.