On Thu, 2013-03-28 at 10:08 -0400, Chris Lumens wrote:
There's no good reason to have multiple places where we define
message
constants and helper functions, when we could just create a class that does
all the hard work for us.
Great idea, straightforward implementation. Nice! Just
one minor
comment:
+ def _makeMethod(self, constant, methodName, argc):
+ def __method(*args):
+ if len(args) != argc:
+ raise TypeError("%s() takes exactly %d arguments (%d given)" %
(methodName, argc, len(args)))
Could you please split this line into two?
Otherwise this looks good to me.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic