I have several general, nitpicky comments:
* I don't like the name "UEFI partitions". We've avoided the word
"partition" in general, and as adamw pointed out in IRC is seems awfully
specific. We'll likely have this same situation on other platforms. Perhaps the name
should be more generic.
* I think it's accidental that these are showing up under a DATA heading. Regardless,
I don't think it belongs under any heading. I think there should probably be a
different Page subclass that these guys live in, similar to how there's an Unknown
page. In fact you might just be able to borrow from that.
* I find it a little weird that there can be multiple selectors with different names but
the same device. I assume that's because it's part of multiple OSes? I feel like
that's hard to discover here. Could they perhaps be grouped together but separated
from other possibly shared UEFI partitions? That is, in the next-to-last screenshot,
could the two sda1s be their own page, vda1s be their own, etc.? I don't know if that
would look good though. It might be more confusing.
* What happens when you delete just the first sda1 selector in the next-to-last
screenshot? Does the other one disappear as well, or do you have to click delete twice to
actually delete one thing?
Thanks for taking a look at this, though. UI stuff is just always tons of nitpicky
details.
--
To view this pull request on github, visit
https://github.com/rhinstaller/anaconda/pull/377