On Sat, 2013-12-21 at 08:39 -0500, Anne Mulhern wrote:
----- Original Message -----
> From: "Brian C. Lane" <bcl(a)redhat.com>
> To: anaconda-patches(a)lists.fedorahosted.org
> Sent: Friday, December 20, 2013 8:07:07 PM
> Subject: Re: [blivet:rhel7/master 1/3] Changes to the handling of
filesystem labeling (#1038590)
>
> On Fri, Dec 20, 2013 at 06:12:51PM -0500, mulhern wrote:
>
> > @@ -682,8 +747,11 @@ class FS(DeviceFormat):
> >
> > @property
> > def labelfsProg(self):
> > - """ Program used to manage labels for this filesystem
type. """
> > - return self._labelfs
> > + """ Program used to manage labels for this filesystem
type.
> > +
> > + May be None if no such program exists.
> > + """
> > + return self._labelfs.name if self._labelfs else None
>
> We avoid the inline if/else construct for readability. The same goes for
> the x = one or another style, for the most part.
>
The very first time I play with my new toy it gets confiscated ;(
Broken out to if statement in working copy.
I must say I like those one-line
constructs and I myself use them quite
often in my patches.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic