On 12/12/2013 01:54 PM, David Shea wrote:
On 12/12/2013 11:51 AM, Vratislav Podzimek wrote:
> On Wed, 2013-12-11 at 14:04 -0500, David Shea wrote:
>> The following classes did not make the cut:
>> - PersonalizationSpoke and its GUI and TUI subclasses
> I believe this is used by the Initial Setup to decide on which spokes to
> include, please check it.
It's not in the code in git. And I wouldn't think that initial setup
needs it, since there's nothing on the hub that would need to be
displayed at the same time as a spoke as far as I know? Also the
anaconda part of this was never really implemented.
>> - TUI ProgressSpoke
> It's not that long ago I switched the TUI ProgressHub into a standalone
> spoke and I believe it works. What is the replacement?
>
>> - StandaloneTUISpoke
> Needed by the ProgressSpoke. Any replacement?
As for these two: whoops, sorry.
>
>> Pretty sure the standalone TUI implementation didn't actually work.
> People see installation progress reported during text installations so I
> believe it works.
>
This comment was based on code I noticed in tui/__init__.py doing
tests for whether a class is an instance of
pyanaconda.ui.tui.spokes.StandaloneSpoke, which doesn't actually
exist. Apparently the import pulls in pyanaconda.ui.common.Standalone
which is imported in tui/spokes/__init__.py, which I didn't know you
could do.
Anyway: if I put back the standalone TUI bits and ProgressSpoke, the
only other thing that needs to be done is ProgressSpoke needs an empty
apply, like SelectDeviceSpoke in patch 7.