On Thu, 2012-12-06 at 10:04 -0600, David Lehman wrote:
On Thu, 2012-12-06 at 14:00 +0100, Vratislav Podzimek wrote:
> On e.g. virtual machines with smalls disks and high amount of
> memory it doesn't make sense to create large swap space leaving
> only a little for the system and user data.
The only concern I have is that the set of available disks can change
and the swap suggestion is only calculated once IIRC. That is why in my
version I did the correction/capping at the time of partition
allocation. Still it wouldn't be too difficult to recalculate the swap
suggestion when leaving the clearpart_disks screen.
Dave
Yeah, I've tested the patch with manual installation and it doesn't
work
because swap suggestion is calculated in an early phase where storage is
not initialized and thus results in 0 causing division by zero later.
I'm trying to modify the patch to recalculate the suggestion when
leaving the clearpart_disks screen.
--
Vratislav Podzimek
Anaconda Rider | Red Hat, Inc. | Brno - Czech Republic