On Fri, 2013-07-19 at 17:53 -0700, Brian C. Lane wrote:
On Fri, Jul 19, 2013 at 10:40:07AM +0200, Vratislav Podzimek wrote:
> On e.g. virtual machines with smalls disks and high amount of
> memory it doesn't make sense to create large swap space leaving
> only a little for the system and user data.
>
> Also change a comment to a docstring and document parameters.
>
> Resolves: rhbz#878907
> Related: rhbz#879232
> if self.recommended or self.hibernation:
> - (self.size, self.maxSizeMB) =
iutil.swapSuggestion(hibernation=self.hibernation)
> + (self.size, self.maxSizeMB) = \
> + iutil.swapSuggestion(hibernation=self.hibernation,
disk_space=disk_space)
Breaking like that makes it less readable. I don't think we really need
to stick with a strict 80 column max anymore. But if you do want to
break the line, do it after the first argument and align the others
with the first:
(self.size, self.maxSizeMB) = iutil.swapSuggestion(hibernation=self.hibernation, \
disk_space=disk_space)
That trailing backslash is not needed since the line break is within
parentheses.