On 07/13/2011 03:54 PM, Jan Provaznik wrote:
On 07/13/2011 03:42 PM, Mark McLoughlin wrote:
> Hey,
>
Hi,
> In the pools pretty list, the link to the default pool details looks
> like:
>
> default_pool Pool details>>
>
> Which looks pretty bad
>
> How about we:
>
> 1) Rename default_pool to "Default Pool" - that seems like a much
> more human friendly name
>
renaming should work (note that default_pool name is probably used both
in seeds and migrations).
I can check if default_pool name has some dependencies and if it's
possible to rename it. If it didn't have an deps I would send a patch
for renaming.
> 2) Add a helper method to make the link "Default Pool
Details" rather
> than "Default Pool Details Details" e.g.
>
> name = pool.name.endswith("Pool") ? pool.name : "#{pool.name}
Pool"
>
Looks like a hack. Why not just change link text to:
1) "#{pool.name} details" or
2) "Pool #{pool.name} details" - yes, in this case "Pool" is twice,
but
if it's a problem, then better to rename default_pool to "Default"
One of text variant can be "Detailed view of #{pool.name}" -> as
it's in
wireframe(run_section.pdf, page 8).
> Any thoughts on that?
>
> Cheers,
> Mark.
>
Jan
> _______________________________________________
> aeolus-devel mailing list
> aeolus-devel(a)lists.fedorahosted.org
>
https://fedorahosted.org/mailman/listinfo/aeolus-devel
_______________________________________________
aeolus-devel mailing list
aeolus-devel(a)lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/aeolus-devel PS: I add Ken to CC, I think
he can decide what will be the best. Here
is BZ link:
https://bugzilla.redhat.com/show_bug.cgi?id=720413
--
Jozef