Whoops - fixing.
Mainn
----- Original Message -----
From: "Jan Provaznik" <jprovazn(a)redhat.com>
To: "Tzu-Mainn Chen" <tzumainn(a)redhat.com>
Cc: aeolus-devel(a)lists.fedorahosted.org
Sent: Tuesday, January 24, 2012 9:53:41 AM
Subject: Re: [PATCH] BZ 773402 enforce maximum length of 50 chars for names, as longer
lengths result in creation errors
On 01/19/2012 10:47 PM, Tzu-Mainn Chen wrote:
---
src/app/models/deployment.rb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/app/models/deployment.rb b/src/app/models/deployment.rb
index bb35b8f..40e251f 100644
--- a/src/app/models/deployment.rb
+++ b/src/app/models/deployment.rb
@@ -64,7 +64,7 @@ class Deployment< ActiveRecord::Base
validates_presence_of :pool_id
validates_presence_of :name
validates_uniqueness_of :name, :scope => :pool_id
- validates_length_of :name, :maximum => 1024
+ validates_length_of :name, :maximum => 50
validates_presence_of :owner_id
validate :pool_must_be_enabled
I think the following failing test is related to the change above:
1) Deployment should have a name of reasonable length
Failure/Error: @deployment.should be_valid
expected valid? to return true, got false
# ./spec/models/deployment_spec.rb:58
the spec tests length of a deployment:
@deployment.name = 'x'*1024
@deployment.should be_valid
Jan