I was setting the FrontendRealm's id as "realm_id", not frontend_realm_id", causing errors when trying to launch a deployment.
-- Matt
--- src/app/views/deployments/_launch_new.haml | 2 +- src/app/views/deployments/_new.haml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/app/views/deployments/_launch_new.haml b/src/app/views/deployments/_launch_new.haml index d5a72d4..896c8e6 100644 --- a/src/app/views/deployments/_launch_new.haml +++ b/src/app/views/deployments/_launch_new.haml @@ -19,7 +19,7 @@ %span.name_available %p Choose a realm - = select :deployment, :realm_id, @realms.map{|r| [r.name, r.id]} + = select :deployment, :frontend_realm_id, @realms.map{|r| [r.name, r.id]} = submit_tag('Next')
:javascript diff --git a/src/app/views/deployments/_new.haml b/src/app/views/deployments/_new.haml index a315a34..1d56959 100644 --- a/src/app/views/deployments/_new.haml +++ b/src/app/views/deployments/_new.haml @@ -45,7 +45,7 @@ - form_for @deployment do = hidden_field :deployment, :name = hidden_field :deployment, :pool_id - = hidden_field :deployment, :realm_id + = hidden_field :deployment, :frontend_realm_id -# FIXME: Passing chunks of XML around in hidden form fields doesn't feel right = hidden_field :deployment, :deployable_xml = submit_tag 'Launch'
On 06/10/2011 06:03 PM, Matt Wagner wrote:
src/app/views/deployments/_launch_new.haml | 2 +- src/app/views/deployments/_new.haml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/app/views/deployments/_launch_new.haml b/src/app/views/deployments/_launch_new.haml index d5a72d4..896c8e6 100644 --- a/src/app/views/deployments/_launch_new.haml +++ b/src/app/views/deployments/_launch_new.haml @@ -19,7 +19,7 @@ %span.name_available %p Choose a realm
- = select :deployment, :realm_id, @realms.map{|r| [r.name, r.id]}
- = select :deployment, :frontend_realm_id, @realms.map{|r| [r.name, r.id]}
Realm is optional parameter so include_blank should be allowed: = select :deployment, :frontend_realm_id, @realms.map{|r| [r.name, r.id]}, { :include_blank => true }
= submit_tag('Next')
:javascript diff --git a/src/app/views/deployments/_new.haml b/src/app/views/deployments/_new.haml index a315a34..1d56959 100644 --- a/src/app/views/deployments/_new.haml +++ b/src/app/views/deployments/_new.haml @@ -45,7 +45,7 @@
- form_for @deployment do = hidden_field :deployment, :name = hidden_field :deployment, :pool_id
- = hidden_field :deployment, :realm_id
- = hidden_field :deployment, :frontend_realm_id -# FIXME: Passing chunks of XML around in hidden form fields doesn't feel right = hidden_field :deployment, :deployable_xml = submit_tag 'Launch'
ACK with one note inline
On Mon, Jun 13, 2011 at 09:59:58AM +0200, Jan Provaznik wrote:
On 06/10/2011 06:03 PM, Matt Wagner wrote:
src/app/views/deployments/_launch_new.haml | 2 +- src/app/views/deployments/_new.haml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/app/views/deployments/_launch_new.haml b/src/app/views/deployments/_launch_new.haml index d5a72d4..896c8e6 100644 --- a/src/app/views/deployments/_launch_new.haml +++ b/src/app/views/deployments/_launch_new.haml @@ -19,7 +19,7 @@ %span.name_available %p Choose a realm
- = select :deployment, :realm_id, @realms.map{|r| [r.name, r.id]}
- = select :deployment, :frontend_realm_id, @realms.map{|r| [r.name, r.id]}
Realm is optional parameter so include_blank should be allowed: = select :deployment, :frontend_realm_id, @realms.map{|r| [r.name, r.id]}, { :include_blank => true }
= submit_tag('Next')
:javascript diff --git a/src/app/views/deployments/_new.haml b/src/app/views/deployments/_new.haml index a315a34..1d56959 100644 --- a/src/app/views/deployments/_new.haml +++ b/src/app/views/deployments/_new.haml @@ -45,7 +45,7 @@
- form_for @deployment do = hidden_field :deployment, :name = hidden_field :deployment, :pool_id
- = hidden_field :deployment, :realm_id
- = hidden_field :deployment, :frontend_realm_id -# FIXME: Passing chunks of XML around in hidden form fields doesn't feel right = hidden_field :deployment, :deployable_xml = submit_tag 'Launch'
ACK with one note inline
Fixed and pushed. Thanks for the review.
-- Matt
aeolus-devel@lists.fedorahosted.org