On 05/19/2011 10:04 PM, mtaylor(a)redhat.com wrote:
From: Martyn Taylor<mtaylor(a)redhat.com>
---
src/db/seeds.rb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/db/seeds.rb b/src/db/seeds.rb
index 3ab3131..8c812ce 100644
--- a/src/db/seeds.rb
+++ b/src/db/seeds.rb
@@ -118,7 +118,7 @@ if ProviderType.all.empty?
ProviderType.create!(:name => "Amazon EC2", :build_supported =>
true, :codename =>"ec2", :ssh_user => "root", :home_dir =>
"/root")
ProviderType.create!(:name => "GoGrid", :codename
=>"gogrid")
ProviderType.create!(:name => "Rackspace", :codename
=>"rackspace")
- ProviderType.create!(:name => "RHEV-M", :codename
=>"rhev-m")
+ ProviderType.create!(:name => "RHEVM", :codename
=>"rhevm")
ProviderType.create!(:name => "OpenNebula", :codename
=>"opennebula")
end
Hey Martyn and all,
Turns out that Deltacloud uses the string 'rhevm' while Image Factory
uses 'rhev-m'. As Conductor depends on both projects, this is something
of a pickle.
Either Deltacloud and Image Factory agree on a single representation or
we'll have to handle this special case in Conductor and send different
values to these services.
I don't like the latter idea as this would complicate the codebase and
could get messier over time (with additional providers coming over).
Since Deltacloud is supposed to be the canonical that everyone builds
upon, I suggest that Image Factory changes its code to use "rhevm".
I grepped the codebase and it seems that there are only 3 instances of
the string floating around. All in the
imagefactory/builders/FedoraBuilder.py so this should be easy to fix.
Changing it on the Deltacloud side would be more complicated.
CCing couple factory and deltacloud folks to get their opinions.
Thomas
--
No trees were killed to send this message, but a large number of
electrons were terribly inconvenienced.