On Tue, Jan 24, 2012 at 11:47:29AM -0500, Matt Wagner wrote:
Fixes issues with h1 overlapping other controls in the admin header.
Resolves
https://bugzilla.redhat.com/show_bug.cgi?id=781286
---
src/app/stylesheets/layout.scss | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/app/stylesheets/layout.scss b/src/app/stylesheets/layout.scss
index d91b3b0..af6afed 100644
--- a/src/app/stylesheets/layout.scss
+++ b/src/app/stylesheets/layout.scss
@@ -1318,6 +1318,7 @@ header.admin-page-header{
text-shadow: 1px 1px 0 #fff;
@include display_inline_block;
padding: 6px 7px 7px 7px;
+ max-width: 490px; /* Otherwise we overlap with other components */
&.disabled{color: #c4c4c4;}
--
1.7.6.5
I apparently botched git send-email and caused the cover I wrote to not
be included.
I noted that this change felt slightly hack-ish because I'm setting this
max-width globally (on all header.admin-page-header h1 elements), but
the width is something optimal for this particular page. However, I
poked around a bit and couldn't find any instances where this wasn't a
reasonable width anyway, so I think it's safe.
I don't *think* we need to set a max-width on the right-hand controls to
prevent them from overlapping the h1 element, as I can't imagine them
getting much wider than they are on this page. But we could set a
max-width: 300px or so if needed.
-- Matt