I was asked to take a gander at #761284. I was unable to reproduce that bug, but I ran
into two problems while trying to do so:
1.) We hide the "New Deployable from Image" button for imported images. This was
a bug I introduced earlier. There's no reason you can't do this, and its absence
renders importing images rather pointless.
2.) There was an error showing on the page to create a new deployable about missing
translations.
To be clear, this is _not_ a fix for #761284 itself, but merely two previously-unnoticed
bugs that I uncovered trying to get there.
This is a trivial fix that I would normally self-ACK, but I'm going to hold off until
Monday to avoid stomping on jzigmund's toes since he owns the BZ.
-- Matt
Show replies by date
---
src/app/views/images/show.html.haml | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/app/views/images/show.html.haml b/src/app/views/images/show.html.haml
index 9da24ab..310cba3 100644
--- a/src/app/views/images/show.html.haml
+++ b/src/app/views/images/show.html.haml
@@ -5,7 +5,6 @@
=t'return_to'
= link_to t('images.index.images'), images_path, :class =>
'rounded-link'
.button-group
- - unless @image.imported?
= link_to t('.new_deployable_from_image'),
new_deployable_path(:create_from_image => @image.id), :class => 'button
pill'
= button_to t("delete"), image_path((a)image.id), :method =>
'delete', :confirm => "Are you sure you want to delete?", :class
=> 'button pill danger', :id => 'delete'
--
1.7.6.4
---
.../views/deployables/_new_from_image.html.haml | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/app/views/deployables/_new_from_image.html.haml
b/src/app/views/deployables/_new_from_image.html.haml
index 0c8edd6..322a23e 100644
--- a/src/app/views/deployables/_new_from_image.html.haml
+++ b/src/app/views/deployables/_new_from_image.html.haml
@@ -34,5 +34,5 @@
.clear
.centered
%fieldset.align-center
- = link_to t('catalog_entries.form.cancel'), catalogs_path, :class =>
'button danger'
- = submit_tag "#{t'catalog_entries.form.save'}", :name =>
'save', :class => 'button primary', :id => 'save_button'
+ = link_to t('deployables.form.cancel'), catalogs_path, :class =>
'button danger'
+ = submit_tag "#{t'deployables.form.save'}", :name =>
'save', :class => 'button primary', :id => 'save_button'
--
1.7.6.4