On 19/09/11 16:58 -0400, Matt Wagner wrote:
The body method is returning a 500 in some cases, which is the root cause of
https://bugzilla.redhat.com/show_bug.cgi?id=735983
As I went to try to debug and maybe rescue this, it occurred to me that I have absolutely
no idea why we're returning 'body' when you fetch its attributes in the first
place. It seems kind of weird, and we don't appear to reference it anywhere in the
code.
So my proposed fix is to remove this behavior. Calling attrs should now be safe. I
didn't change body to rescue exceptions, since I don't have any idea what we
should do in that case, so raising an exception seems like the right thing to do.
It would be great if someone who knew this code well could give this a quick sanity check,
though.
-- Matt
_______________________________________________
ACK, pushed. However, this has exposed that the list method is
unbelieveably slow, so we need to figure out why asap.
-j