On 07/07/2011 12:01 PM, Mark McLoughlin wrote:
This is completely unused now since commit 4d780212edf.
---
src/app/models/provider_type.rb | 1 -
src/app/views/provider_types/_list.xml.haml | 1 -
...4_remove_build_supported_from_provider_types.rb | 9 +++++++++
src/db/seeds.rb | 8 ++++----
src/features/provider_type.feature | 16 ++++++++--------
.../step_definitions/provider_type_steps.rb | 4 +---
6 files changed, 22 insertions(+), 17 deletions(-)
create mode 100644
src/db/migrate/20110707145144_remove_build_supported_from_provider_types.rb
ACK with one required change. The patch as-written broke the cucumber
test that was being altered, the changed lines were missing the required
ending '|'
So this is a friendly reminder to always run spec/cucumber tests before
sending a patch along :-)
diff --git a/src/features/provider_type.feature
b/src/features/provider_type.feature
index c1d39a1..859452d 100644
--- a/src/features/provider_type.feature
+++ b/src/features/provider_type.feature
@@ -12,11 +12,11 @@ Feature: Manage Providers
When I go to the provider types page
Then I should get a XML document
And there should be these provider types:
- | name | codename | build_supported |
- | Mock | mock | true |
- | GoGrid | gogrid | false |
- | Rackspace | rackspace | false |
- | OpenNebula | opennebula | false |
- | Amazon EC2 | ec2 | true |
- | CondorCloud | condorcloud | true |
- | RHEV-M | rhevm | false |
+ | name | codename
+ | Mock | mock
+ | GoGrid | gogrid
+ | Rackspace | rackspace
+ | OpenNebula | opennebula
+ | Amazon EC2 | ec2
+ | CondorCloud | condorcloud
+ | RHEV-M | rhevm
instead of the above, this section of the patch should
look like this:
diff --git a/src/features/provider_type.feature
b/src/features/provider_type.feature
index c1d39a1..5479b42 100644
--- a/src/features/provider_type.feature
+++ b/src/features/provider_type.feature
@@ -12,11 +12,11 @@ Feature: Manage Providers
When I go to the provider types page
Then I should get a XML document
And there should be these provider types:
- | name | codename | build_supported |
- | Mock | mock | true |
- | GoGrid | gogrid | false |
- | Rackspace | rackspace | false |
- | OpenNebula | opennebula | false |
- | Amazon EC2 | ec2 | true |
- | CondorCloud | condorcloud | true |
- | RHEV-M | rhevm | false |
+ | name | codename |
+ | Mock | mock |
+ | GoGrid | gogrid |
+ | Rackspace | rackspace |
+ | OpenNebula | opennebula |
+ | Amazon EC2 | ec2 |
+ | CondorCloud | condorcloud |
+ | RHEV-M | rhevm |
With this change, all tests succeed with the patch. I've pushed the
modified patch.
Scott