NACK, afaik we want to see list of non stopped instances by default. so
the non-stopped instances filter as default is correct.
On 01/11/2012 04:25 PM, ifarkas(a)redhat.com wrote:
From: Imre Farkas<ifarkas(a)redhat.com>
https://bugzilla.redhat.com/show_bug.cgi?id=770623
---
src/app/controllers/pools_controller.rb | 1 -
src/features/pool.feature | 6 +++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/app/controllers/pools_controller.rb
b/src/app/controllers/pools_controller.rb
index 76c6d5a..2133a7a 100644
--- a/src/app/controllers/pools_controller.rb
+++ b/src/app/controllers/pools_controller.rb
@@ -47,7 +47,6 @@ class PoolsController< ApplicationController
when 'pools'
@pools = Pool.list_for_user(current_user,
Privilege::VIEW).apply_filters(:preset_filter_id => params[:pools_preset_filter],
:search_filter => params[:pools_search]).list(sort_column(Pool), sort_direction)
when 'instances'
- params[:instances_preset_filter] = "other_than_stopped" unless
params[:instances_preset_filter]
@instances = Instance.apply_filters(:preset_filter_id =>
params[:instances_preset_filter], :search_filter =>
params[:instances_search]).list(sort_column(Instance), sort_direction)
when 'deployments'
@deployments = Deployment.apply_filters(:preset_filter_id =>
params[:deployments_preset_filter], :search_filter =>
params[:deployments_search]).list(sort_column(Deployment), sort_direction)
diff --git a/src/features/pool.feature b/src/features/pool.feature
index b52d7f6..c6d20ea 100644
--- a/src/features/pool.feature
+++ b/src/features/pool.feature
@@ -194,12 +194,12 @@ Feature: Manage Pools
And I follow "details_instances"
And I should see "mock1"
And I should see "mock2"
- And I should not see "mock3"
- When I select "" from "instances_preset_filter"
+ And I should see "mock3"
+ When I select "Non-stopped Instances" from
"instances_preset_filter"
And I press "apply_instances_preset_filter"
And I should see "mock1"
And I should see "mock2"
- And I should see "mock3"
+ And I should not see "mock3"
Scenario: Select Catalog Images on pool detail page
Given a pool "mockpool" exists