On Mon, 2011-07-11 at 14:16 +0200, Tomas Sedovic wrote:
On 07/05/2011 09:58 AM, Mark McLoughlin wrote:
> If you resize the browser window until the main content starts running
> out of room, notice that the content overlaps with the footer.
>
> Add a 40px empty div to the primary container to prevent the overlap,
> copying a suggestion from here:
>
>
http://ryanfait.com/resources/footer-stick-to-bottom-of-page/
> ---
> src/app/stylesheets/layout.scss | 6 ++++--
> src/app/views/layouts/application.haml | 3 +++
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/src/app/stylesheets/layout.scss b/src/app/stylesheets/layout.scss
> index d8e8315..24adc9c 100644
> --- a/src/app/stylesheets/layout.scss
> +++ b/src/app/stylesheets/layout.scss
> @@ -663,7 +663,6 @@ $contentpadding: 7px;
> div#content{
> width: $width - (2 * $contentpadding);
> margin: 0 auto;
> - margin-bottom: 98px;
> min-height: 200px;
> -webkit-border-radius: 7px; -moz-border-radius: 7px; border-radius: 7px;
> background-color: #FAFAFA;
> @@ -2512,11 +2511,14 @@ Page Footer -- v.0.0.1 [footer] (footer.scss)
>
> /* Footer */
>
> +footer.standard, .push{
> + height: 40px;
> +}
> +
> footer.standard{
>
> background: rgba(0, 0, 0, 0.20);
> position: relative;
> - height: 40px;
> width: 100%;
> font-size: 11px;
> clear:both;
> diff --git a/src/app/views/layouts/application.haml
b/src/app/views/layouts/application.haml
> index 443af7f..bdacde1 100644
> --- a/src/app/views/layouts/application.haml
> +++ b/src/app/views/layouts/application.haml
> @@ -45,6 +45,9 @@
> = yield
> .clear
>
> + - # forces the footer to not overlap
> + .push
> +
> %footer.standard
> .container
> = image_tag('footer-rhlogo.png', :id => 'logo')
Hey Mark,
This does what it's supposed to so I'm inclined to ack this.
Thanks
However, I'd like to give Ken as our resident UX guy a chance to
veto.
Of course, that's why I cc-ed Ken
The patch was actually meant as more of an RFC for Ken
Also, the layout.scss file is autogenerated from the aeolus_uxdev
repo,
we shouldn't add manual changes to it.
Ah, is there are README or something which explains that?
You can either ask Ken to include the changes there or put them to
the
custom.scss file here in Conductor. That file exists for hand-made
stylesheet modifications.
Modifying the original source is probably what makes most sense
Thanks,
Mark.