On Wednesday 09 November 2011 01:06:39 Scott Seago wrote:
On 11/08/2011 04:29 AM, jzigmund(a)redhat.com wrote:
> This patchset contains all subtasks of #2721
Hi,
So I made a few comments inline for a couple of the patches.
A few comments on the UI now.
Overall, it does seem to work fine. However, there are a few issues that
I think ought to be addressed.
First, this form should have 2 options for generating the content -- The
user should be able to upload the XML from a file like you have, but the
user should also be able to supply a URL for the XML. The overall flow
should be similar to the first couple screens in the'new template/image'
form. In particular, there should be a way to swap between the 'upload'
and 'url' versions of the form, like is done in these two mockups from
Ken's buildpush_r8 sequence:
For upload: 03 New Template (Upload).png
For URL:
04 New Template (URL, blank).png
05 New Template (URL) Copy.png
06 New Template (URL) Copy 1.png
In either case, there's then the opportunity to edit, in a form similar
to this:
07 Edit Template.png
Finally, we need to validate the XML using the XML validation code that
we have, with a confirmation screen similar to this:
08 Finish Template.png
The refactoring above for allowing URL and upload of the template could
perhaps be implemented as a separate follow-on patch (so we've got the
new model in place, allowing other aspects of the build/push UI to start
sooner). There are a couple bits that should be addressed as part of
this patchset:
First, there's no validation of the XML on upload done currently -- I
was able to save a deployable that was just random text.
For the launch UI, we can get rid of the "Load definition from XML" text
-- it should probably be blank to indicate that the user must choose
something here. The prior text "Load definition from URL" was there so
the user could choose _not_ to pick a catalog entry and simply enter the
URL instead.
I noticed that the properties page shows the xml in a tiny field --
currently there are about 2 lines by about 20 characters, which doesn't
allow you to see much. However this page is being completely reworked to
match Ken's "11 Deployable Details.png" as a separate task, so I
wouldn't worry about this part just yet.
So, in summary -- to push this patchset we just need to get the
validation on saving a catalog entry fixed, the minor "Load definition
from XML" fix, and the inline comments on the other patches. The more
substantial UI rework to allow deployable creation via URL or file
upload should be done as a follow-on patch once this patchset is pushed.
Scott
Thank you Scott for review, it seems that I misunderstood that we want to
remove URL only from the launch form, as you pointed out.
--
Jozef Zigmund